Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add joins on the orders list query builder conditionally #15132

Merged
merged 2 commits into from Jul 4, 2023
Merged

Add joins on the orders list query builder conditionally #15132

merged 2 commits into from Jul 4, 2023

Conversation

jakubtobiasz
Copy link
Member

Q A
Branch? 1.13
Bug fix? no/
New feature? no
BC breaks? no
Deprecations? no
Related tickets closes #14781
License MIT

@jakubtobiasz jakubtobiasz added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Admin AdminBundle related issues and PRs. labels Jun 27, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner June 27, 2023 16:00
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 27, 2023
@vvasiloi
Copy link
Contributor

WDYT about adding a new createCriteriaSearchListQueryBuilder method and deprecating the current one instead of changing the signature?

@jakubtobiasz
Copy link
Member Author

@vvasiloi Seems like a safer way 👍🏼. I'll change it tomorrow.

@jakubtobiasz jakubtobiasz force-pushed the SYL-2964 branch 3 times, most recently from f1f2f84 to 27dc9aa Compare June 28, 2023 06:59
NoResponseMate
NoResponseMate previously approved these changes Jun 28, 2023
View reviewed changes
UPGRADE-1.13.md Outdated Show resolved Hide resolved
@jakubtobiasz jakubtobiasz force-pushed the SYL-2964 branch 2 times, most recently from 955e18f to 0af95ef Compare June 29, 2023 07:21
@GSadee GSadee merged commit 142e94b into Sylius:1.13 Jul 4, 2023
23 checks passed
@GSadee
Copy link
Member

GSadee commented Jul 4, 2023

Thanks, Jacob! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate left review comments

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin order list heavy query
4 participants
@jakubtobiasz @vvasiloi @GSadee @NoResponseMate