Make fixtures code more clean & re-usable #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjedrzejewski @winzou Please merge this ASAP =) Fixtures are broken without that |
|
Actually, do we still need the pending state? I think this is the same as "on hold". @winzou |
|
Onhold means payment is pending. @stloyd payum needs the unknown state you deleted, build is failing for that, |
Remove unused states for some models
|
@pjedrzejewski ping. |
winzou
added a commit
that referenced
this pull request
May 17, 2014
Make fixtures code more clean & re-usable
|
Thanks |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Make fixtures code more clean & re-usable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally fixes two issues:
pendingstate for Shipping in Finite configuration,constdeclared at model not interface