Fix attributes creation while the default locale is not available in our store #15218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Aug 10, 2023
•
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #X |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
TheMilek
changed the title
TheMilek
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
…g when not using default locale
GSadee
requested changes
Aug 17, 2023
...tributes/seeing_correct_select_attribute_values_in_different_locale_than_default_one.feature
Outdated
Show resolved
Hide resolved
...tributes/seeing_correct_select_attribute_values_in_different_locale_than_default_one.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductAttributesContext.php
Outdated
Show resolved
Hide resolved
...tributeBundle/Form/Type/AttributeType/Configuration/SelectAttributeChoicesCollectionType.php
Outdated
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
SYL-2816
branch
from
5f12eb3
to
a9546e0
Compare
jakubtobiasz
approved these changes
Aug 18, 2023
| @@ -1,3 +1,9 @@ | |||
| # UPGRADE FROM `v1.12.9` TO `v1.12.10` | |||
There was a problem hiding this comment.
Suggested change
| # UPGRADE FROM `v1.12.9` TO `v1.12.10` | |
| # UPGRADE FROM `v1.12.10` TO `v1.12.11` |
GSadee
approved these changes
Aug 18, 2023
|
Thanks, Kamil! 🎉 |
GSadee
added a commit
that referenced
this pull request
Aug 18, 2023
…cesCollectionType (NoResponseMate) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | yes | | Related tickets | continues #15218 | | License | MIT | Commits ------- 9b930d7 [Maintenance] Note deprecation in SelectAttributeChoicesCollectionType
GSadee
added a commit
that referenced
this pull request
Aug 18, 2023
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | after #15218 (review) | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 0974db2 Fix Sylius versions in UPGRADE file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.