Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[State machine] Replace shipment and item events #1526

Merged
merged 3 commits into from
May 21, 2014

Conversation

winzou
Copy link
Contributor

@winzou winzou commented May 19, 2014

  • add a generic updateStateAction in ResourceController, to easily update a state via a proper StateMachine.

@@ -52,10 +53,12 @@ public function resolveOrderStates(GenericEvent $event)

public function resolveOrderStatesFinite(TransitionEvent $event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not relevant for this PR, but I think we should get rid of this Finite suffix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@winzou
Copy link
Contributor Author

winzou commented May 21, 2014

All green :)

pjedrzejewski pushed a commit that referenced this pull request May 21, 2014
[State machine] Replace shipment and item events
@pjedrzejewski pjedrzejewski merged commit b913f7a into Sylius:master May 21, 2014
@pjedrzejewski
Copy link
Member

Thank you Alexandre!

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[State machine] Replace shipment and item events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants