Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the User class compatible with Symfony 6 to use encoder_name #15287

Merged
merged 3 commits into from Nov 17, 2023

Conversation

delyriand
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #15286
License MIT

@delyriand delyriand requested a review from a team as a code owner September 12, 2023 08:05
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz
Copy link
Member

Hello @delyriand 👋🏼,
can you add a note about the changed model's interface to the 1.12's upgrade file, please?

lchrusciel
lchrusciel previously approved these changes Sep 16, 2023
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jacob ask should be added, but all in all, that's a good change 👍

Roshyo
Roshyo previously approved these changes Sep 17, 2023
@delyriand delyriand dismissed stale reviews from Roshyo and lchrusciel via 6399d47 September 18, 2023 07:22
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Sep 18, 2023
@delyriand delyriand force-pushed the fix/15286-user-compatibility-sf6 branch 2 times, most recently from 5f7f862 to 905f62d Compare September 18, 2023 07:28
@delyriand
Copy link
Contributor Author

Hi @jakubtobiasz!

I've just added a step to the update file for version 1.12.

@diimpp
Copy link
Member

diimpp commented Sep 18, 2023

Sylius uses https://github.com/SyliusLabs/PolyfillSymfonySecurity which handles interface mismatch for UserInterface as well, should this fix be added over there, while SF5 is supported?

@loic425 Hi, what do you think?

@loic425
Copy link
Member

loic425 commented Sep 18, 2023

Sylius uses https://github.com/SyliusLabs/PolyfillSymfonySecurity which handles interface mismatch for UserInterface as well, should this fix be added over there, while SF5 is supported?

@loic425 Hi, what do you think?

That's a good question, the existing Pollyfill is to create a bc-layer to keep compatibility with legacy Symfony versions.
It's for complex bc-layer, here it's simple cause it works with Symfony 5 and 6.

diimpp
diimpp previously approved these changes Sep 18, 2023
Prometee
Prometee previously approved these changes Oct 6, 2023
@GSadee GSadee dismissed stale reviews from Prometee and diimpp via 6cb8c0d November 17, 2023 10:52
@GSadee GSadee force-pushed the fix/15286-user-compatibility-sf6 branch from 6cb8c0d to 0d116c6 Compare November 17, 2023 11:01
@GSadee GSadee merged commit 9519ded into Sylius:1.12 Nov 17, 2023
25 checks passed
@GSadee
Copy link
Member

GSadee commented Nov 17, 2023

Thank you, Maxime! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants