New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the User class compatible with Symfony 6 to use encoder_name #15287
Make the User class compatible with Symfony 6 to use encoder_name #15287
Conversation
delyriand
commented
Sep 12, 2023
Q | A |
---|---|
Branch? | 1.12 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | fixes #15286 |
License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
Hello @delyriand 👋🏼, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jacob ask should be added, but all in all, that's a good change 👍
5f7f862
to
905f62d
Compare
Hi @jakubtobiasz! I've just added a step to the update file for version 1.12. |
Sylius uses https://github.com/SyliusLabs/PolyfillSymfonySecurity which handles interface mismatch for UserInterface as well, should this fix be added over there, while SF5 is supported? @loic425 Hi, what do you think? |
That's a good question, the existing Pollyfill is to create a bc-layer to keep compatibility with legacy Symfony versions. |
6cb8c0d
to
0d116c6
Compare
Thank you, Maxime! 🥇 |