[API] Cover editing and deleting channels #15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Oct 19, 2023
•
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
TheMilek
force-pushed
the
SYL-3152
branch
3 times, most recently
from
ba5dffb
to
c1e9325
Compare
Rafikooo
reviewed
Oct 19, 2023
features/channel/managing_channels/selecting_default_tax_zone_for_channel.feature
Show resolved
Hide resolved
features/channel/managing_channels/editing_shop_billing_data_on_channel.feature
Outdated
Show resolved
Hide resolved
features/channel/managing_channels/selecting_tax_calculation_strategy_for_channel.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingChannelsBillingDataContext.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/EventSubscriber/ChannelDeletionEventSubscriberSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/EventSubscriber/ChannelDeletionEventSubscriberSpec.php
Outdated
Show resolved
Hide resolved
|
/bns:start |
diimpp
reviewed
Oct 20, 2023
features/channel/managing_channels/choosing_required_address_in_checkout_for_channel.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventSubscriber/ChannelDeletionEventSubscriber.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Exception/ChannelCannotBeRemoved.php
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3152
branch
3 times, most recently
from
2056830
to
d758fe9
Compare
probot-autolabeler
bot
added
the
Maintenance
TheMilek
force-pushed
the
SYL-3152
branch
2 times, most recently
from
cf45ed1
to
ee4bf28
Compare
Wojdylak
previously approved these changes
Oct 25, 2023
jakubtobiasz
previously approved these changes
Oct 25, 2023
src/Sylius/Behat/Context/Ui/Admin/ManagingChannelsBillingDataContext.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventSubscriber/ChannelDeletionEventSubscriber.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventSubscriber/ChannelDeletionEventSubscriber.php
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3152
branch
2 times, most recently
from
c417e15
to
3d6d5ec
Compare
GSadee
reviewed
Oct 26, 2023
...res/channel/managing_channels/adding_channel_with_set_period_of_showing_lowest_price.feature
Outdated
Show resolved
Hide resolved
features/channel/managing_channels/choosing_required_address_in_checkout_for_channel.feature
Outdated
Show resolved
Hide resolved
features/channel/managing_channels/not_being_able_to_delete_last_available_channel.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingChannelsBillingDataContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventSubscriber/ChannelDeletionEventSubscriber.php
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3152
branch
3 times, most recently
from
d7d9f7a
to
9cc78aa
Compare
GSadee
previously approved these changes
Oct 31, 2023
jakubtobiasz
previously approved these changes
Oct 31, 2023
Wojdylak
previously approved these changes
Oct 31, 2023
NoResponseMate
previously approved these changes
Oct 31, 2023
TheMilek
dismissed stale reviews from NoResponseMate, Wojdylak, and jakubtobiasz
via
4004fa3
Wojdylak
previously approved these changes
Nov 2, 2023
Rafikooo
previously approved these changes
Nov 3, 2023
jakubtobiasz
reviewed
Nov 6, 2023
src/Sylius/Bundle/ApiBundle/EventListener/ChannelDeletionEventListener.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
SYL-3152
branch
from
2e05cbc
to
b70c7b8
Compare
jakubtobiasz
force-pushed
the
SYL-3152
branch
from
b70c7b8
to
8d4214d
Compare
GSadee
approved these changes
Nov 7, 2023
Comment on lines
+32
to
33
| - Sylius\Behat\Context\Api\Admin\ManagingChannelsBillingDataContext | ||
| - Sylius\Behat\Context\Api\Admin\ManagingChannelPriceHistoryConfigsContext |
There was a problem hiding this comment.
Suggested change
| - Sylius\Behat\Context\Api\Admin\ManagingChannelsBillingDataContext | |
| - Sylius\Behat\Context\Api\Admin\ManagingChannelPriceHistoryConfigsContext | |
| - Sylius\Behat\Context\Api\Admin\ManagingChannelPriceHistoryConfigsContext | |
| - Sylius\Behat\Context\Api\Admin\ManagingChannelsBillingDataContext |
|
Thank you, Kamil! 🎉 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.