Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent division by zero #15518

Merged
merged 5 commits into from Nov 24, 2023
Merged

Prevent division by zero #15518

merged 5 commits into from Nov 24, 2023

Conversation

cbastienbaron
Copy link
Contributor

Q A
Branch? 1.12 or 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no-->
Related tickets
License MIT

just more robust code

@cbastienbaron cbastienbaron requested a review from a team as a code owner November 10, 2023 13:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz
Copy link
Member

Hi @cbastienbaron 👋🏼,
Thanks for your contribution! Would you like to write a specification for this concrete case?

Hint: src/Sylius/Component/Core/spec/Customer/Statistics/PerChannelCustomerStatisticsSpec.php 😅

@cbastienbaron
Copy link
Contributor Author

hey @jakubtobiasz thanks for the hint ^^ spec has been added 🤞

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jakubtobiasz jakubtobiasz reopened this Nov 14, 2023
@cbastienbaron
Copy link
Contributor Author

thanks u @diimpp for review 👍 resolved 🤞

lchrusciel
lchrusciel approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me welcome you among Sylius contributors :)

@lchrusciel lchrusciel merged commit 81340dd into Sylius:1.13 Nov 24, 2023
30 checks passed
@lchrusciel
Copy link
Member

Thank you, @cbastienbaron!

@lchrusciel
Copy link
Member

or it should be even merged to 1.12 :/

@cbastienbaron
Copy link
Contributor Author

@lchrusciel Thanks you for yours kinds words 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prometee Prometee Prometee approved these changes

@diimpp diimpp diimpp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@oallain oallain oallain approved these changes

@loic425 loic425 loic425 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cbastienbaron @jakubtobiasz @lchrusciel @Prometee @diimpp @oallain @loic425