Disable check for security vulnerabilites step #15527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Nov 14, 2023
Wojdylak
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | N/A |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
fix-ci-11142023
branch
from
1226356
to
5a1f03c
Compare
GSadee
approved these changes
Nov 14, 2023
|
Thank you, Karol! 🎉 |
mbabker
reviewed
Nov 14, 2023
|
|
||
| - `doctrine/doctrine-bundle:2.11.0`: | ||
|
|
||
| This version uses the [readonly property](https://github.com/doctrine/DoctrineBundle/blob/2.11.0/Repository/ServiceEntityRepositoryProxy.php#L34), which is available from PHP 8.1 while the package also supports PHP 7.4 and 8.0, leading to compatibility issues. |
There was a problem hiding this comment.
This really shouldn't be needed, the file you're linking is conditionally loaded by the "real" class downstream users are meant to be using, and this case it would be only when doctrine/orm:^3.0 is installed (which requires PHP 8.1 anyway). Sounds like this might be another case of a static analysis tool being over-eager?
There was a problem hiding this comment.
We managed to solve it in #15531. Thanks for rising this topic :)!
jakubtobiasz
added a commit
that referenced
this pull request
Nov 14, 2023
…dylak) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #15527 | License | MIT [link](#15527 (comment)) Commits ------- Add ignore parse errors to composer require checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.