[FIX] Default variant #15548
Merged
[FIX] Default variant #15548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
loevgaard
reviewed
Nov 20, 2023
src/Sylius/Bundle/ProductBundle/Doctrine/ORM/ProductVariantRepository.php
Outdated
Show resolved
Hide resolved
loevgaard
reviewed
Nov 20, 2023
src/Sylius/Component/Product/Repository/ProductVariantRepositoryInterface.php
Outdated
Show resolved
Hide resolved
loevgaard
reviewed
Nov 20, 2023
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
added
Bug
|
So it was a regression. We need a test to prevent that from happening again. |
Prometee
force-pushed
the
fix-default-variant
branch
from
9661a16
to
4cb00eb
Compare
probot-autolabeler
bot
added
the
Maintenance
diimpp
reviewed
Nov 20, 2023
src/Sylius/Bundle/ProductBundle/Doctrine/ORM/ProductVariantRepository.php
Outdated
Show resolved
Hide resolved
Prometee
force-pushed
the
fix-default-variant
branch
from
4cb00eb
to
69463f0
Compare
Prometee
force-pushed
the
fix-default-variant
branch
from
69463f0
to
a48a8c8
Compare
@vvasiloi Scenario added 😉 |
Prometee
commented
Nov 20, 2023
features/product/viewing_products/viewing_product_price_on_products_list.feature
Outdated
Show resolved
Hide resolved
vvasiloi
reviewed
Nov 20, 2023
features/product/viewing_products/viewing_product_price_on_products_list.feature
Show resolved
Hide resolved
Prometee
force-pushed
the
fix-default-variant
branch
from
59290bc
to
d0fc9e2
Compare
|
Do I have to silent the PSALM error ? Any other way to circle around this error ? |
Maybe just use |
|
Or we remove psalm 😆 /cc @jakubtobiasz |
Prometee
force-pushed
the
fix-default-variant
branch
from
d0fc9e2
to
3d72280
Compare
vvasiloi
reviewed
Nov 20, 2023
src/Sylius/Component/Product/Resolver/DefaultProductVariantResolver.php
Outdated
Show resolved
Hide resolved
…olver.php Co-authored-by: Victor Vasiloi <victor.vasiloi@gmail.com>
Prometee
force-pushed
the
fix-default-variant
branch
from
c48127c
to
10a5de6
Compare
vvasiloi
previously approved these changes
Nov 20, 2023
vvasiloi
approved these changes
Nov 20, 2023
oallain
approved these changes
Nov 20, 2023
lchrusciel
approved these changes
Nov 22, 2023
|
Thank you, @Prometee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an issue introduced by #15273.
Variants are by default ordered by position via a specific Doctrine resource configuration :
https://github.com/Sylius/Sylius/blob/1.12/src/Sylius/Bundle/ProductBundle/Resources/config/doctrine/model/Product.orm.xml#L37-L38
This behaviour has to be cloned to retrieve the right variant.