New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve actions and rules configuration validation #15551
Merged
TheMilek
merged 22 commits into
Sylius:1.13
from
Wojdylak:SYL-3231-resolver-actions-and-rules-configuration-validation
Nov 28, 2023
Merged
Resolve actions and rules configuration validation #15551
TheMilek
merged 22 commits into
Sylius:1.13
from
Wojdylak:SYL-3231-resolver-actions-and-rules-configuration-validation
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Nov 21, 2023
Q | A |
---|---|
Branch? | 1.13 |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Related tickets | N/A |
License | MIT |
probot-autolabeler
bot
added
API
APIs related issues and PRs.
Maintenance
CI configurations, READMEs, releases, etc.
labels
Nov 21, 2023
Wojdylak
force-pushed
the
SYL-3231-resolver-actions-and-rules-configuration-validation
branch
from
November 21, 2023 07:49
18a149e
to
69be9e8
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
SYL-3231-resolver-actions-and-rules-configuration-validation
branch
5 times, most recently
from
November 21, 2023 13:52
eb27d9c
to
3dec414
Compare
Wojdylak
force-pushed
the
SYL-3231-resolver-actions-and-rules-configuration-validation
branch
from
November 22, 2023 07:36
c65f2ed
to
77124ac
Compare
Wojdylak
changed the title
🚧 Resolver actions and rules configuration validation
Resolver actions and rules configuration validation
Nov 22, 2023
TheMilek
previously approved these changes
Nov 22, 2023
GSadee
previously approved these changes
Nov 24, 2023
src/Sylius/Bundle/ApiBundle/Validator/Constraints/PromotionActionGroupValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/PromotionRuleGroupValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/ChannelCodeCollectionValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Validator/Constraints/ChannelCodeCollectionValidatorSpec.php
Outdated
Show resolved
Hide resolved
Wojdylak
force-pushed
the
SYL-3231-resolver-actions-and-rules-configuration-validation
branch
from
November 24, 2023 16:58
a170fe2
to
42f6aca
Compare
jakubtobiasz
previously approved these changes
Nov 27, 2023
src/Sylius/Behat/Context/Api/Admin/ManagingPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/OpenApi/Documentation/PromotionDocumentationModifier.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/PromotionExampleFactory.php
Show resolved
Hide resolved
jakubtobiasz
approved these changes
Nov 27, 2023
Wojdylak
changed the title
Resolver actions and rules configuration validation
Resolve actions and rules configuration validation
Nov 28, 2023
TheMilek
approved these changes
Nov 28, 2023
Thank you, @Wojdylak! |
Wojdylak
deleted the
SYL-3231-resolver-actions-and-rules-configuration-validation
branch
November 30, 2023 07:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.