BUGFIX: #12681 add missing required class to provincecode select input #15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full thanks goes to @acornforth ❤️ ! Since it was his idea for implemeting this solution! I only saw, it wasnt implemented, and i could still reproduce the issue he described in #12681 |
Bunnyshell Preview Environment deletedAvailable commands:
|
Rafikooo
approved these changes
Feb 27, 2024
TheMilek
approved these changes
Feb 27, 2024
Wojdylak
approved these changes
Feb 27, 2024
|
Thank you, @crydotsnake! |
|
Thanks for implementing this @crydotsnake, I changed jobs, and don't work with Sylius on a daily anymore, but my former colleagues will appreciate this a lot |
|
Your welcome ! @acornforth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #12681:
Currently when you choose a country with configured provinces, the province select input isnt visualy marked as required with a
*. When you try to submit the address form without choosing a province, it will tell you:With this change, the
requiredclass will be added to theprovinceContainer. Then it becomes visible again: