-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: [AdminBundle] #15890 Introduce sylius:admin-user:list command #15946
base: 1.13
Are you sure you want to change the base?
FEATURE: [AdminBundle] #15890 Introduce sylius:admin-user:list command #15946
Conversation
Bunnyshell Preview Environment deployment failedCheck https://github.com/Sylius/Sylius/actions/runs/8143979577 for details. Available commands:
|
By default, all available admin users will be display. But you can also show only one admin user with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @crydotsnake for another contribution,
It would be awesome if you could try to test this feature, you can refer to how we tested other, similar CLI command here: https://github.com/Sylius/Sylius/pull/14571/files#diff-0cc123576bf137514df3bef27330b372df9d5016c6e3a27cbe1c29338934e1d5R26
Yes. Good point 🤦🏼♂️ will take a look at it. A test for #15889 would be good aswell.. |
$this->io->table( | ||
[ | ||
'ID', 'E-Mail', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled', | ||
], | ||
[ | ||
[ | ||
$adminUser->getId(), | ||
$adminUser->getEmail(), | ||
$adminUser->getUsername(), | ||
$adminUser->getFirstname() ?? 'No Firstname Set', | ||
$adminUser->getLastName() ?? 'No Lastname Set', | ||
$adminUser->getLocaleCode(), | ||
$adminUser->isEnabled() ? 'Enabled' : 'Disabled', | ||
], | ||
], | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could call the ::listSingleAdminUser
here instead. It seems the content is the same 👋
Hello @crydotsnake, are you still interested in completing this task? We want to incorporate this feature, however, Sylius 1.13-RC version has been released, so this pull request should now be directed to the 2.0 branch 💃 |
Hello @Rafikooo ! Yes, i'm. But i had no time to work on the tests so far 😓. |
Description:
As described in: #15890
This pull request introduces a new CLI command:
By default all available admin users are listed, and each data of a user is showed in a table:
If you want to see only one admin user, you can use the
--username
option:Any feedback or improvement ideas are much appreciated!