[PaymentRequest] Automatically cancel all pending payment requests when the payment method gets changed #15950
+5,519
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Mar 5, 2024
•
TheMilek
commented
| Q | A |
|---|---|
| Branch? | payment-request |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
TheMilek
force-pushed
the
SYL-3368
branch
3 times, most recently
from
915f378
to
64305ce
Compare
…iority when the test_cached_payum env is used
src/Sylius/Bundle/ApiBundle/Resources/config/services/event_subscribers.xml
Outdated
Show resolved
Hide resolved
Comment on lines
15
to
21
| @no-ui @api | ||
| Scenario: Cancelling the payment request when payment method is changed | ||
| Given I added product "Iron Maiden T-Shirt" to the cart | ||
| And I have proceeded selecting "PayPal" payment method | ||
| When I confirm my order with paypal payment | ||
| And I change payment method to "Offline" after checkout | ||
| Then the payment request for payment method "PayPal" should be cancelled |
There was a problem hiding this comment.
Suggested change
| @no-ui @api | |
| Scenario: Cancelling the payment request when payment method is changed | |
| Given I added product "Iron Maiden T-Shirt" to the cart | |
| And I have proceeded selecting "PayPal" payment method | |
| When I confirm my order with paypal payment | |
| And I change payment method to "Offline" after checkout | |
| Then the payment request for payment method "PayPal" should be cancelled | |
| @no-ui @api | |
| Scenario: Cancelling the payment request when payment method is changed | |
| Given I added product "Iron Maiden T-Shirt" to the cart | |
| And I have proceeded selecting "PayPal" payment method | |
| And I confirm my order with paypal payment # <- I'm wondering whether it's necessary as we have "I have proceeded" | |
| When I change payment method to "Offline" after checkout | |
| Then the payment request for payment method "PayPal" should be cancelled |
IMO confirm is a part of preparation, and When starts for this scenario when I want to change the payment method. Also I'm wondering whether the I confirm can be skipped here.
There was a problem hiding this comment.
I renamed it a bit, as yeah it might be misleading
This PR was merged into the payment-request branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | `payment-request` Commits ------- Create an environment for payumless tests Add workflows using the test_cached_payumless env Rename the test_cached_payumless environment to test_cached_payum Change the 'sylius.payment_request.command_provider.payum.offline' priority when the test_cached_payum env is used Fix Payum-related tests
TheMilek
force-pushed
the
SYL-3368
branch
2 times, most recently
from
931cbb1
to
258ffda
Compare
…ngful exceptions or remove some of them (TheMilek) This PR was merged into the payment-request branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | payment-request <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- Make some methods non nullable Add new exceptions Remove unecessary asserts or convert them to exceptions Rename PaymentRequestChecker to provider Use just find() repository method instead of creating a new one
jakubtobiasz
approved these changes
Mar 13, 2024
GSadee
reviewed
Mar 14, 2024
| And the store ships everywhere for Free | ||
| And the store allows paying Offline | ||
| And the store has a payment method "PayPal" with a code "PAYPAL" and Paypal Express Checkout gateway | ||
| And there is a customer "sylius@example.com" that placed an order "#00000022" |
There was a problem hiding this comment.
This step seems not to be needed in this scenario
Suggested change
| And there is a customer "sylius@example.com" that placed an order "#00000022" |
| @paying_for_order | ||
| Feature: Cancelling payment request when payment method is changed | ||
| In order to pay with the correct payment method | ||
| As a Customer |
There was a problem hiding this comment.
The actor is a visitor, not a customer, as there is no login step in the scenario
Suggested change
| As a Customer | |
| As a Visitor |
There was a problem hiding this comment.
But only customer can change the payment method (once you bought anything, you became a customer), so IMO the actor is valid here.
|
|
||
| foreach ($commands as $command) { | ||
| if ($this->isNotValid($command) || $method !== Request::METHOD_PATCH) { | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| continue; |
Should we check other arguments?
| $method = $event->getRequest()->getMethod(); | ||
|
|
||
| foreach ($commands as $command) { | ||
| if ($this->isNotValid($command) || $method !== Request::METHOD_PATCH) { |
There was a problem hiding this comment.
The method could be checked before the foreach
| * | ||
| * @return array<PaymentRequestInterface> | ||
| */ | ||
| public function findByStatesAndPaymentId(array $states, int|string $paymentId): array |
There was a problem hiding this comment.
Suggested change
| public function findByStatesAndPaymentId(array $states, int|string $paymentId): array | |
| public function findByPaymentIdAndStates(int|string $paymentId, array $states): array |
🤔
lchrusciel
force-pushed
the
payment-request
branch
from
e9f340c
to
202f77f
Compare
|
@TheMilek can you rebase this PR, your changes are lost in my commits :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.