Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add product/taxon name in meta title #160

Closed
wants to merge 1 commit into from

Conversation

piotrantosik
Copy link
Contributor

@pjedrzejewski - simple question - can i use methods metaDescription/metaKeywords product to improve seo, currently is building in form but not displaying in view (maybe you are planning to remove them)?

@umpirsky
Copy link
Contributor

@piotrantosik Any advantages of | separator over - in terms of SEO?

@ghost
Copy link

ghost commented Jun 13, 2013

i'd like the seperator to be configurable

@umpirsky
Copy link
Contributor

We can use twig globals. Or maybe some advanced meta system with twig extension.

@ghost
Copy link

ghost commented Jun 13, 2013

sonata seo bundle does that.

@umpirsky
Copy link
Contributor

@pjedrzejewski
Copy link
Member

@piotrantosik Yes! That's their original purpose. :) We should start with that, and I'll look at SonataSeoBundle.

@ghost
Copy link

ghost commented Jun 13, 2013

i wonder if the 20 truncation is too small. imo that should definitely be decoupled from the display.

@umpirsky
Copy link
Contributor

Why truncate at all?

@ghost
Copy link

ghost commented Jun 13, 2013

SEO reasons, although there is quite the debate as to what the correct/best length is.

@umpirsky
Copy link
Contributor

Ah, right. I read 70 somewhere. So it depends on parent length.

Regards,
Saša Stamenković

On Thu, Jun 13, 2013 at 12:10 PM, Johnny Robeson
notifications@github.comwrote:

SEO reasons, although there is quite the debate as to what the
correct/best length is.


Reply to this email directly or view it on GitHubhttps://github.com//pull/160#issuecomment-19382964
.

@ghost
Copy link

ghost commented Jun 13, 2013

i asked if @rande would make his exporter lib optional in SonataSeoBundle here: sonata-project/SonataSeoBundle#18

@pjedrzejewski
Copy link
Member

Closing for now, I'd like this to be more configurable like @jrobeson said.

@cordoval
Copy link
Contributor

there is work trying to tie symfony-cmf/seo-bundle#146 with sylius, first custom but then we may try if successful to send a PR. I am using non-cmf ORM first approach because my sylius store is without cmf yet, a 0.7.0 version 😊 but i think the concepts should be the same.

pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
@piotrantosik piotrantosik deleted the feature/seo-title branch May 18, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants