-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add product/taxon name in meta title #160
Conversation
@piotrantosik Any advantages of |
i'd like the seperator to be configurable |
We can use twig globals. Or maybe some advanced meta system with twig extension. |
sonata seo bundle does that. |
@jrobeson Thanks for the reference. https://github.com/sonata-project/SonataSeoBundle/blob/master/Twig/Extension/SeoExtension.php |
@piotrantosik Yes! That's their original purpose. :) We should start with that, and I'll look at SonataSeoBundle. |
i wonder if the 20 truncation is too small. imo that should definitely be decoupled from the display. |
Why truncate at all? |
SEO reasons, although there is quite the debate as to what the correct/best length is. |
Ah, right. I read 70 somewhere. So it depends on parent length. Regards, On Thu, Jun 13, 2013 at 12:10 PM, Johnny Robeson
|
i asked if @rande would make his exporter lib optional in SonataSeoBundle here: sonata-project/SonataSeoBundle#18 |
Closing for now, I'd like this to be more configurable like @jrobeson said. |
there is work trying to tie symfony-cmf/seo-bundle#146 with sylius, first custom but then we may try if successful to send a PR. I am using non-cmf ORM first approach because my sylius store is without cmf yet, a 0.7.0 version 😊 but i think the concepts should be the same. |
Update installation.rst
@pjedrzejewski - simple question - can i use methods metaDescription/metaKeywords product to improve seo, currently is building in form but not displaying in view (maybe you are planning to remove them)?