[PoC] Improved DX while creating forms with Twig Hooks #16284
+581
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deployment failedCheck https://github.com/Sylius/Sylius/actions/runs/9188164850 for details. Available commands:
|
…us twig components
…h the `sylius_admin:form` anonymous component
…ent in Admin User
jakubtobiasz
force-pushed
the
bap/improve-dx-forms
branch
from
70bef86
to
0e2c9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have been forced to (let's be honest) duplicate hooks configuration for the
create/updatepage. In most cases they were exactly the same, and it was annoying.The idea is to extract the form to a separate anonymous component, add two additional hook names (
sylius_admin.common.component.formandsylius_admin.<resource_name>.component.formand configure most of the hookables using thesylius_admin.<resource_name>.component.form.You can see the example here: 70bef86
Moreover, if we want to add a field only on the
update/createpage it is possible thanks to already existingsylius_admin.<resource_name>.(create/update)hooks.