Add additional address toggle in checkout #16405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
|
The script itself is okay, but it's always better to write something more general in case you need to use the show/hide mechanism elsewhere in the future. Fortunately, we don't need to because Bootstrap already has such a script. We just need to write a listener that will react to the checkbox instead of the button. https://getbootstrap.com/docs/5.3/components/collapse As for IDs, we try not to use IDs but rather data-... because later it's unclear whether the attribute is used for identification/scripts/styles or something else. |
|
thanks @bartek-sek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.