Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations being moved from Crowdin into old removed/renamed bundles #1652

Merged
merged 1 commit into from
Jun 28, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Jun 26, 2014

Additionally, the importing/exporting script from Crowdin must be updated to match new structure.

@jjanvier
Copy link
Contributor

@stloyd, what is the new structure ?

@jjanvier
Copy link
Contributor

Plus, I didn't have sync English translations on Crowdin yet. I first wanted to get all others translations from Crowdin before doing it. Because I'm sure we'll loose a few translations if English keys has changed.

@stloyd
Copy link
Contributor Author

stloyd commented Jun 26, 2014

@jjanvier There is no: PromotionsBundle, there is: PromotionBundle, no PaymentsBundle but PaymentBundle etc.

@jjanvier
Copy link
Contributor

@stloyd, oh you're right, I missed that. Thanks, I'll update it on Crowdin.

pjedrzejewski pushed a commit that referenced this pull request Jun 28, 2014
Fix translations being moved from Crowdin into old removed/renamed bundles
@pjedrzejewski pjedrzejewski merged commit 7357d3a into Sylius:master Jun 28, 2014
@pjedrzejewski
Copy link
Member

Thanks Joseph!

@stloyd stloyd deleted the bugfix/translations branch June 28, 2014 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants