Locale bundle #1670
Merged
Locale bundle #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #1490. |
|
Huge PR, it is quite difficult to review it :) |
|
@Arn0d This are two PRs in one :) Just last commit belongs to this PR in fact... |
|
ok 👶 ! |
|
Yup, @stloyd is right. :) |
| { | ||
| $this->getLocaleContext()->setLocale($locale); | ||
|
|
||
| return $this->redirect($request->headers->get('referer')); |
There was a problem hiding this comment.
You should check it has this header...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted locales management stuff from core to separate component + bundle.
Added ability to switch the language in the frontend.
That's the first step for making Sylius fully i18n. I want the Locale component to support multiple areas, so that you can have different lang in backend/frontend or per store.