Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of ideas how we could fix problem with those translation keys #1675

Merged
merged 1 commit into from
Dec 11, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Jul 1, 2014

No description provided.

@stloyd
Copy link
Contributor Author

stloyd commented Aug 9, 2014

@pjedrzejewski @jjanvier ping

@arnolanglade
Copy link
Contributor

👍

@stloyd
Copy link
Contributor Author

stloyd commented Sep 4, 2014

@pjedrzejewski @jjanvier We need to fix this, and I know it's not nice to "waste" already created translations for keys, but if auto-sync can't migrate them, we need such change.

Missing on translations Crowdin are still better than missing in layout cause of broken keys.

@stloyd
Copy link
Contributor Author

stloyd commented Oct 1, 2014

@pjedrzejewski @jjanvier We really need to fix this before 0.11 release IMO.

@pjedrzejewski
Copy link
Member

@jjanvier Any idea? Is there any way to update crowdin keys? I'd like to rename/modify few to miminize the amount of translation keys, without losing existing translations...

@stloyd
Copy link
Contributor Author

stloyd commented Nov 1, 2014

@pjedrzejewski @jjanvier @Arn0d @umpirsky We definitely need to fix this ASAP, it's really sad we released 0.11 with bugged translations...

@pjedrzejewski
Copy link
Member

@jjanvier seems to be off. (e-mails as well) I'd like to get his insight since he knows best how Crowdin sync works.

@stloyd
Copy link
Contributor Author

stloyd commented Nov 1, 2014

@pjedrzejewski I guess that best way would to at least give access to the core team to code that does that syncs etc. or totally open-source it. Otherwise Sylius is being really limited to one person that "knows how it works" which is really bad IMO.

@pjedrzejewski
Copy link
Member

Yes, the idea was to open source it of course - AFAIK it is a set of commands. I'll try to get in touch with Julien and release whatever we have...

@stloyd
Copy link
Contributor Author

stloyd commented Nov 27, 2014

@pjedrzejewski @jjanvier @Arn0d Guys, we really need to fix this issue, next month passes and we still didn't fix this annoying bug...

@stloyd
Copy link
Contributor Author

stloyd commented Dec 10, 2014

@pjedrzejewski @jjanvier @Arn0d We must fix this once and for all, we must not release yet another broken release!

@pjedrzejewski
Copy link
Member

@stloyd You are right, I will hold on with v0.12.0, hopefully we can get quick answer from @jjanvier if this will work, because I'm not sure if modifying the keys here won't break the crowdin sync.

pjedrzejewski pushed a commit that referenced this pull request Dec 11, 2014
One of ideas how we could fix problem with those translation keys
@pjedrzejewski pjedrzejewski merged commit 454dea0 into Sylius:master Dec 11, 2014
@pjedrzejewski
Copy link
Member

OK, I will merge this to release v0.12.0, especially because we need to rework a lot of translation keys anyway... There is too much duplication.

@pjedrzejewski
Copy link
Member

Thanks Joseph!

@stloyd stloyd deleted the bugfix/translation_keys branch December 11, 2014 08:29
@stloyd
Copy link
Contributor Author

stloyd commented Dec 11, 2014

@pjedrzejewski I will look for similar cases in other translation as I guess that I could miss something...

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
One of ideas how we could fix problem with those translation keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants