[ResourceBundle] Api request should not return RedirectResponse #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Merged
|
@pjedrzejewski updated! |
| @@ -30,7 +30,8 @@ | |||
| "friendsofsymfony/rest-bundle": "~1.0", | |||
| "jms/serializer-bundle": "~0.12", | |||
| "white-october/pagerfanta-bundle": "1.0.*", | |||
| "doctrine/doctrine-bundle": "~1.3@dev" | |||
| "doctrine/doctrine-bundle": "~1.3@dev", | |||
| "willdurand/hateoas-bundle": "@stable" | |||
There was a problem hiding this comment.
You need to register that bundle in Kernel to be able to use it functionality.
There was a problem hiding this comment.
This must be added to main composer.json file too.
|
@Arn0d Could you update composer.lock to include hateoas stuff? Can't see it in the diff. :) |
|
Just run |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jul 4, 2014
[ResourceBundle] Api request should not return RedirectResponse
|
I will do this cause I need it. :D Thanks Arnaud! |
|
Sorry, I was doing several things at the same time ! ✌️ |
|
No worries! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete, create and update actions return a RedirectResponse, we lost some advantages of the
FosRestBundle.I know that some methods has a lot of return has a lot of return, some developer does not like it but I have not problem with it. I need it ASAP for a project so I am here if you want to talk about this !