Allow to get taxons from specific taxonomy #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
pushed a commit
that referenced
this pull request
Jul 15, 2014
Allow to get taxons from specific taxonomy
| interface TaxonsAwareInterface | ||
| { | ||
| /** | ||
| * Get all taxons. |
There was a problem hiding this comment.
This is wrong, it can return one taxon, also better would be to add new method instead of hack around in old one.
There was a problem hiding this comment.
Are you sure? It seems like its just copied from src/Sylius/Component/Core/Model/ProductInterface.php
There was a problem hiding this comment.
@sstok Look at diff, old version don't have parameter, new one uses it to hack around and return specific taxon which is wrong IMO, cause it should be in new method.
|
If the method took in a Taxonomy object, you could save some database calls by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
TaxonsAwareInterfaceand allow to get taxons from specific taxonomy.