[WIP] Adding a resource form type #1772
Conversation
| $options['validation_groups'] = $this->validationGroups; | ||
| } | ||
|
|
||
| $resolver->setDefaults($options); |
There was a problem hiding this comment.
IMO good enough would be:
$resolver->setDefaults(array(
'data_class' => $this->dataClass,
'validation_groups' => $this->validationGroups,
));Cause anyway you have validation done on resolver (if not we should add it).
|
If we go this way, that class should be in |
|
@stloyd For sure! I don't know what I did... SettingBundle.... |
|
@stloyd, Done. @pjedrzejewski what do you think ? |
| protected $dataClass = null; | ||
|
|
||
| /** | ||
| * @var array |
|
Looks good, I guess you should adjust forms in repository to reduce the duplication ;) |
|
@stloyd Every forms should be updated. @pjedrzejewski this one? or I open another one? |
|
Sounds good to me. I am fine with adjusting them in this PR. I will make sure to merge it quick and avoid conflicts. |
|
@pjedrzejewski I will updated ASAP (I am in holidays for a week) |
|
@pjedrzejewski, @stloyd, sometime form only need data class, sometime only they need validation groups or they need both... Setter could be better but the service definitions should be rewritten... Both solutions are huge... I just update form which used data class or the both? Any opinion on this ? |
arnolanglade
changed the title
|
Some form type constructors change, I need to manage it. |
arnolanglade
force-pushed
the
resource/base-form
branch
from
dfb5e80
to
861d053
Compare
| protected $actionRegistry; | ||
|
|
||
| public function __construct($dataClass, array $validationGroups, ServiceRegistryInterface $actionRegistry) | ||
| { | ||
| $this->dataClass = $dataClass; | ||
| $this->validationGroups = $validationGroups; | ||
| parent::__construct($dataClass, $validationGroups, $actionRegistry); |
There was a problem hiding this comment.
$actionRegistry must be removed here.
arnolanglade
force-pushed
the
resource/base-form
branch
from
861d053
to
ed7780b
Compare
|
@stloyd Fixed :) |
|
@pjedrzejewski what do you about it ? |
[WIP] Adding a resource form type
|
@Arn0d I love the diff stats, it is a good refactoring. ;) Thank you very much! 👍 |
I already submit a PR like that but it was a little bit different. I use resource bundle for custom development and I create this form all the time, it is really annoying! If you are agree with this I can update the Sylius's form in a other PR.