Improvements to the attribute subject interface descriptions and setAttributes method argument name. #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamelso can you squash your commits please ? |
|
@Arn0d Do you mean combine the 2 commits into a single commit? |
|
@adamelso yes sir ! |
|
@Arn0d Okay, completed. :) |
Additionally remove references to 'product' from docblock descriptions.
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 20, 2014
…nostic Improvements to the attribute subject interface descriptions and setAttributes method argument name.
|
👍 Thank you Adam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst implementing the Attribute Component, I noticed that
setAttributes(Collection $properties)should besetAttributes(Collection $attributes). I assume this occurred during some refactoring but it did confuse me a little bit. Also I took the opportunity to update the descriptions as they are still referring to theProduct, and contain duplications. Additionally the grammar has been improved too :)