[CurrencyBundle] Add command to allow updating exchange rates using ECB database

[stloyd]

ECB = European Central Bank

[pjedrzejewski]

I think we need something more generic... Command is fine, but it should be able to use different adapters. Exchange rates updating service sounds like a solution to me. What do you think?

[stloyd]

@pjedrzejewski I agree... but currently this is one step forward where we don't have any real option to handle this ;)

If you give me some example database that can be used instead of ECB I will try to add them as more generic case, otherwise I think it's ok for now, and make it more generic when we have usecase (other databases) to handle.

[kayue]

https://openexchangerates.org/

[pjedrzejewski]

^ this. I just think it can be really simple implementation with adapters or providers. :)

[stloyd]

@pjedrzejewski @kayue @Arn0d I guess it's ready for first review.

[kayue]

Personally I prefer full name instead of OERImporter, other than that it looks good to me 👍

Thanks @stloyd .

[stloyd]

@kayue For me both versions are ok, so I can give full names and add aliases for short names.

[stloyd]

@Arn0d @kayue @pjedrzejewski Anything missing for this?

[pjedrzejewski]

Looks like a good start to me! I agree with Ka Yue for both points, I think we should improve it with tagged services and use full names.

Thank you very much Joseph! 👍

[Djuki]

@pjedrzejewski My team and I have worked on a similar feature. We have Multiple Exchange Rate Providers (ECB, Google, Yahoo)

Also we have cli Command for updating all rates. We have phpspec included.

Is it too late for us to send PR? Perhaps you could take a look?

I would like to hear your opinion about our approach and work. I know you accepted this PR but maybe it is not too late to take a look at another similar PR.

[stloyd]

@Djuki I guess there is no problem to adapt your code to merged one ;) So feel free to create PR :)

[pjedrzejewski]

@Djuki Yes, please go ahead and send the PR! 👍 I'd love to see how can we use it!