Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PromotionBundle] Add missing dependency on CurrencyBundle #1866

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Sep 4, 2014

Fixes #1191.

@pjedrzejewski
Copy link
Member

Should be money bundle actually. :)

@stloyd
Copy link
Contributor Author

stloyd commented Sep 4, 2014

Hmmm... It's really confusing as CurrencyBundle have same stuff...

@pjedrzejewski
Copy link
Member

Currency bundle extends MoneyBundle to use the currently selected currency in the form type. Money bundle is enough for promotion.

@stloyd
Copy link
Contributor Author

stloyd commented Sep 4, 2014

@pjedrzejewski Adjusted.

pjedrzejewski pushed a commit that referenced this pull request Sep 4, 2014
[PromotionBundle] Add missing dependency on CurrencyBundle
@pjedrzejewski pjedrzejewski merged commit 8a4e0ef into Sylius:master Sep 4, 2014
@stloyd stloyd deleted the patch-3 branch September 4, 2014 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PromotionsBundle] Some dependencies are not found
2 participants