Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OrderBundle] Add ability to lock order adjustments #1923

Merged
merged 1 commit into from
Oct 3, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Sep 21, 2014

Fixes #1915.

TODO:

/**
* {@inheritdoc}
*/
public function setLocked($locked)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to add lock() and unlock() method aliases for such models. Just an idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock and unlock +1

@stloyd stloyd force-pushed the feature/adjustment_lock branch 2 times, most recently from 67993e1 to aaa2df4 Compare September 23, 2014 08:09
@stloyd stloyd force-pushed the feature/adjustment_lock branch 2 times, most recently from bd549d7 to fc1f890 Compare October 1, 2014 09:40
@stloyd stloyd changed the title [WIP][OrderBundle] Add ability to lock order adjustments [OrderBundle] Add ability to lock order adjustments Oct 1, 2014
@stloyd
Copy link
Contributor Author

stloyd commented Oct 1, 2014

I guess it's ready now.

screen

@stloyd
Copy link
Contributor Author

stloyd commented Oct 3, 2014

@pjedrzejewski Anything blocking this?

pjedrzejewski pushed a commit that referenced this pull request Oct 3, 2014
[OrderBundle] Add ability to lock order adjustments
@pjedrzejewski pjedrzejewski merged commit 8269ec2 into Sylius:master Oct 3, 2014
@stloyd stloyd deleted the feature/adjustment_lock branch October 3, 2014 09:15
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[OrderBundle] Add ability to lock order adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Adjustment locking
4 participants