-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OrderBundle] Add ability to lock order adjustments #1923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function setLocked($locked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to add lock()
and unlock()
method aliases for such models. Just an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock and unlock +1
67993e1
to
aaa2df4
Compare
1 task
bd549d7
to
fc1f890
Compare
fc1f890
to
7cdf582
Compare
7cdf582
to
44fc3a2
Compare
@pjedrzejewski Anything blocking this? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 3, 2014
[OrderBundle] Add ability to lock order adjustments
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[OrderBundle] Add ability to lock order adjustments
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[OrderBundle] Add ability to lock order adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1915.
TODO: