[Inventory] Availability checker must check that variant was not deleted #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjedrzejewski @Arn0d @umpirsky What do you think? |
| @@ -42,7 +43,11 @@ public function __construct($backorders) | |||
| */ | |||
| public function isStockAvailable(StockableInterface $stockable) | |||
| { | |||
| if (true === $this->backorders || $stockable->isAvailableOnDemand()) { | |||
| if ($stockable instanceof SoftDeletableInterface && $stockable->isDeleted()) { | |||
There was a problem hiding this comment.
isDeleted() method is not defined in StockableInterface.
There was a problem hiding this comment.
That's why this checks for SoftDeletableInterface ;)
There was a problem hiding this comment.
@stloyd Oh, blind me, sorry.
stloyd
force-pushed
the
bugfix/inventory_check
branch
from
66a80d1
to
1c06543
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 23, 2014
[Inventory] Availability checker must check that variant was not deleted
|
Thanks Joseph! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813.