Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contentbundle] dependencies fixes #2013

Merged
merged 1 commit into from
Oct 14, 2014

Conversation

arnolanglade
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR No need

@@ -43,5 +44,6 @@
"branch-alias": {
"dev-master": "0.11-dev"
}
}
},
"minimum-stability": "dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think we prefer to use @dev on concrete unstable deps. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried lot of thing I forget to remove it! IIRC I see it in other bundle.

@arnolanglade
Copy link
Contributor Author

@pjedrzejewski I removed "minimum-stability": "dev" but I found it in several bundles (almost all). FYI I am writing the spec for the content forms.

@arnolanglade
Copy link
Contributor Author

@pjedrzejewski ping !

pjedrzejewski pushed a commit that referenced this pull request Oct 14, 2014
[Contentbundle] dependencies fixes
@pjedrzejewski pjedrzejewski merged commit 30ea202 into Sylius:master Oct 14, 2014
@pjedrzejewski
Copy link
Member

Thanks Arnaud!

@arnolanglade
Copy link
Contributor Author

✌️

@arnolanglade arnolanglade deleted the content/composer branch December 16, 2014 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants