Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreBundle] Remove hardcoded classes in order item form #2028

Merged
merged 1 commit into from
Oct 16, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Oct 16, 2014

Fixes #1996 & #1997

@stloyd
Copy link
Contributor Author

stloyd commented Oct 16, 2014

@umpirsky Is this ok for you?

@umpirsky
Copy link
Contributor

@stloyd 👍

pjedrzejewski pushed a commit that referenced this pull request Oct 16, 2014
[CoreBundle] Remove hardcoded classes in order item form
@pjedrzejewski pjedrzejewski merged commit 2b15b72 into Sylius:master Oct 16, 2014
@pjedrzejewski
Copy link
Member

Would be cool to create a generic entity hidden + autocomplete field. Where you specify the class for autocomplete etc. Thanks Joseph!

@stloyd stloyd deleted the bugfix/hardcoded_classes branch October 16, 2014 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded data_class in OrderItemType
3 participants