Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null value #2059

Merged

Conversation

MichaelMackus
Copy link
Contributor

Should handle null value here, or promotions usage limit should not be nullable.

Fixes #2077

Should handle null value here, or promotions usage limit should not be nullable.
@stloyd
Copy link
Contributor

stloyd commented Oct 27, 2014

👍

@kayue
Copy link
Contributor

kayue commented Oct 28, 2014

We just ran into this problem yesterday 👍

@stloyd
Copy link
Contributor

stloyd commented Oct 29, 2014

@pjedrzejewski @Arn0d @umpirsky Can you merge this ASAP?

pjedrzejewski pushed a commit that referenced this pull request Oct 29, 2014
@pjedrzejewski pjedrzejewski merged commit f4a4afa into Sylius:master Oct 29, 2014
@pjedrzejewski
Copy link
Member

Thank you @MichaelMackus!

@MichaelMackus MichaelMackus deleted the promotion-handle-null-usage-limit branch October 29, 2014 20:03
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to apply promotion without usage limit
4 participants