[WebBundle] Fix invalid html markup for payments forms #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjedrzejewski @Arn0d ping... |
|
Hi, I think too that hide the form is the best solution ;) |
| {{ buttons.edit(path('sylius_backend_payment_update', {'id': payment.id})) }} | ||
| {%- endif %} | ||
|
|
||
| {% for transition in ['cancel', 'complete', 'refund'] if sm_can(payment, transition, 'sylius_payment') -%} |
There was a problem hiding this comment.
Why not create a twig partial for this form ?
This is the same in the _details view, no, ? except for the hr tag.
There was a problem hiding this comment.
Yeah, maybe it makes sense?
Added easier way to change states & hide editing for non super admins
stloyd
force-pushed
the
bugfix/payments_forms
branch
from
720583e
to
4ec7178
Compare
|
@pjedrzejewski @Arn0d ping... |
|
@pjedrzejewski Can we get this fix merged? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 9, 2014
[WebBundle] Fix invalid html markup for payments forms
|
Thanks Joseph! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added easier way to change states & hide editing for non super admins.
Fixes #1993, replaces #2005.