Allowing translations to be easily extracted

[jjanvier]

When extracting Core or Web bundles translations, we always face this exception :

   [Doctrine\Common\Annotations\AnnotationException]                                                                                                        
   [Semantical Error] The annotation "@Given" in method Behat\MinkExtension\Context \MinkContext::iAmOnHomepage() was never imported. Did you maybe forget to add a "use" statement for this annotation? 

As explained by everzet himself here https://github.com/Behat/MinkBundle/issues/29 this PR resolves, the problem.

[stloyd]

IMO this is not right place, mostly because it fails only for behat, not globally.

[umpirsky]

Entire Behat directory can be ignored by adding ignore option when running
extract command.
On 29 Jun 2013 13:49, "Julien Janvier" notifications@github.com wrote:

When extracting Core or Web bundles translations, we always face this
exception :

[Doctrine\Common\Annotations\AnnotationException]
[Semantical Error] The annotation "@given" in method Behat\MinkExtension\Context \MinkContext::iAmOnHomepage() was never imported. Did you maybe forget to add a "use" statement for this annotation?

As explained by everzet himself here Behat/MinkBundle#29https://github.com/Behat/MinkBundle/issues/29this PR resolves, the problem.

You can merge this Pull Request by running

git pull https://github.com/jjanvier/Sylius translations

Or view, comment on, or merge it at:

#212
Commit Summary

• Allowing translations to be easily extracted

File Changes

• M app/autoload.phphttps://github.com/Allowing translations to be easily extracted #212/files#diff-0(8)
• M
  src/Sylius/Bundle/WebBundle/Controller/Backend/DashboardController.phphttps://github.com/Allowing translations to be easily extracted #212/files#diff-1(4)

Patch Links:

• https://github.com/Sylius/Sylius/pull/212.patch
• https://github.com/Sylius/Sylius/pull/212.diff

[umpirsky]

Maybe we should wrap extraction into single command to extract translations
for entire project.
On 29 Jun 2013 14:22, "Saša Stamenković" umpirsky@gmail.com wrote:

Entire Behat directory can be ignored by adding ignore option when running
extract command.
On 29 Jun 2013 13:49, "Julien Janvier" notifications@github.com wrote:

When extracting Core or Web bundles translations, we always face this
exception :

[Doctrine\Common\Annotations\AnnotationException]
[Semantical Error] The annotation "@given" in method Behat\MinkExtension\Context \MinkContext::iAmOnHomepage() was never imported. Did you maybe forget to add a "use" statement for this annotation?

As explained by everzet himself here Behat/MinkBundle#29https://github.com/Behat/MinkBundle/issues/29this PR resolves, the problem.

You can merge this Pull Request by running

git pull https://github.com/jjanvier/Sylius translations

Or view, comment on, or merge it at:

#212
Commit Summary

• Allowing translations to be easily extracted

File Changes

• M app/autoload.phphttps://github.com/Allowing translations to be easily extracted #212/files#diff-0(8)
• M
  src/Sylius/Bundle/WebBundle/Controller/Backend/DashboardController.phphttps://github.com/Allowing translations to be easily extracted #212/files#diff-1(4)

Patch Links:

• https://github.com/Sylius/Sylius/pull/212.patch
• https://github.com/Sylius/Sylius/pull/212.diff

[jjanvier]

@umpirsky I really like your solution. So I close this PR.

[sargath]

@umpirsky I got a question about translations, I extracted translations from every bundle separately, should I then PR as separate translation for every bundle or put it to SyliusWebBundle , what's the strategy for them right now ?

[umpirsky]

Bundles are independent, so separate PR for each is the way to go.
On 30 Jun 2013 12:57, "Sargath" notifications@github.com wrote:

@umpirsky https://github.com/umpirsky I got a question about
translations, I extracted translations from every bundle separately, should
I then PR as separate translation for every bundle or put it to
SyliusWebBundle , what's the strategy for them right now ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/212#issuecomment-20245463
.