Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreBundle] Enable override of routing config #2122

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

QuingKhaos
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets n/a
License MIT
Doc PR n/a

I wanted to add the paginatate parameter to the sylius key for the generated routes. But without the change the configuration merge doesn't preserve keys and looked like the following:

sylius_core:
    routing:
        %sylius.model.taxon.class%:
            field: permalink
            prefix: /t
            defaults:
                controller: sylius.controller.product:indexByTaxonAction
                sylius:
                    template: SyliusWebBundle:Frontend/Product:indexByTaxon.html.twig
                0:
                    paginate: 9

With this change the configs get correctly merged to this:

sylius_core:
    routing:
        %sylius.model.taxon.class%:
            field: permalink
            prefix: /t
            defaults:
                controller: sylius.controller.product:indexByTaxonAction
                sylius:
                    template: SyliusWebBundle:Frontend/Product:indexByTaxon.html.twig
                    paginate: 9

@stloyd
Copy link
Contributor

stloyd commented Nov 9, 2014

@pjedrzejewski @Arn0d Looks good for me...

pjedrzejewski pushed a commit that referenced this pull request Nov 11, 2014
[CoreBundle] Enable override of routing config
@pjedrzejewski pjedrzejewski merged commit 6f6f4be into Sylius:master Nov 11, 2014
@pjedrzejewski
Copy link
Member

👍

@QuingKhaos QuingKhaos deleted the fix/core-config-merge branch November 11, 2014 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants