[Variation] Reusable Set Builders for generating variants + VariantGenerator spec coverage #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Nice, let's wait for the build. :) I think it is not a problem if someone does not know what a Cartesian product is. With these changes, the design is better and generation easier to change, so 👍. |
adamelso
changed the title
| @@ -0,0 +1,62 @@ | |||
| <?php | |||
|
|
|||
| namespace Sylius\Component\Variation\SetBuilder; | |||
adamelso
force-pushed
the
variant-generator-specs
branch
from
44a8987
to
8d0c583
Compare
|
@stloyd Thanks, I've addressed your comments and have squashed the commits. |
|
|
||
| if (1 === $countArrays) { | ||
| return reset($setTuples); | ||
| } elseif (0 === $countArrays) { |
There was a problem hiding this comment.
Should be just if as you call return in previous one.
adamelso
force-pushed
the
variant-generator-specs
branch
from
8d0c583
to
4fa52f6
Compare
|
@pjedrzejewski ping... |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 13, 2015
[Variation] Reusable Set Builders for generating variants + VariantGenerator spec coverage
|
Thank you Adam! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Variation] Reusable Set Builders for generating variants + VariantGenerator spec coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on writing specs for the
VariantGenerator, I could see why there weren't any to begin with.Now the most complicated logic has been extracted out to a new class
CartesianSetBuilder, which implementsSetBuilderInterface, so this has the added benefit of allowing developers to define their own strategies for generating variants.Unfortunately, the disadvantage of this being that the set builder has to be explicitly passed to the constructor of
VariantGenerator, and only math boffins would be aware of what a set builder and the Cartesian product are.