[PromotionBundle] The collection form type uses the new CollectionExtension #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnolanglade
commented
Dec 9, 2014
arnolanglade
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Behat? | no |
| Phpspec? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
arnolanglade
added
PromotionBundle
Enhancement
| ->add('type', 'sylius_promotion_rule_choice', array( | ||
| 'label' => 'sylius.form.rule.type' | ||
| )) | ||
| ->addEventSubscriber(new BuildRuleFormListener($this->checkerRegistry, $builder->getFormFactory()), $options['rule_type']) |
There was a problem hiding this comment.
Wrongly placed ). Should be:
- ->addEventSubscriber(new BuildRuleFormListener($this->checkerRegistry, $builder->getFormFactory()), $options['rule_type'])
+ ->addEventSubscriber(new BuildRuleFormListener($this->checkerRegistry, $builder->getFormFactory(), $options['rule_type']))
arnolanglade
force-pushed
the
promotion
branch
5 times, most recently
from
b58acd2
to
7b06c01
Compare
|
@pjedrzejewski I need to fix spec and behat but what do you think about it? |
|
|
||
| /** | ||
| * Shipping country rule configuration form type. | ||
| * | ||
| * @author Saša Stamenković <umpirsky@gmail.com> | ||
| */ | ||
| class ShippingCountryConfigurationType extends AbstractResourceType | ||
| class ShippingCountryConfigurationType extends AbstractType |
There was a problem hiding this comment.
because of 'class' => $this->dataClass. class is not data_class.
|
Looks really good to me, nice work Arnaud! 👍 |
arnolanglade
force-pushed
the
promotion
branch
3 times, most recently
from
3461d16
to
8e0a5f6
Compare
|
@Sylius/core-team / @stloyd It is time to code review ! |
|
@Arn0d Looks good for me, nice job ;) |
arnolanglade
force-pushed
the
promotion
branch
from
8e0a5f6
to
0eb0887
Compare
|
You guys, I get exactly the same errors than the country form (I speak about behat). I run them manually and it works! @pjedrzejewski what do you think ? |
|
ping @pjedrzejewski |
arnolanglade
changed the title
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 16, 2014
[PromotionBundle] The collection form type uses the new CollectionExtension
|
Thank you Arnaud! Really nice work! 👍 |
|
✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.