[Order]WIP order identities #2243
Conversation
Allow multiple identities for orders, typically used for storing external identifications, such as an backend (ERP) order id.
| @@ -48,6 +48,12 @@ | |||
| </cascade> | |||
| </one-to-many> | |||
|
|
|||
| <one-to-many field="identities" target-entity="Sylius\Component\Order\Model\IdentityInterface" mapped-by="order" orphan-removal="true"> | |||
| <cascade> | |||
| <cascade-all/> | |||
There was a problem hiding this comment.
Maybe cascade persist, because order is soft-deleted and we would prefer to keep these as well. :)
|
Forget the blank line comments, I just saw the WIP comment, but this is an excellent feature. I would definitely like to have it in core. :) Thanks man and let me know if you need any help/answers. |
|
@pjedrzejewski Cool. The Identity concept could also be used for Products and Users (eg. if you want to sync them to OroCRM as account). In such case it would be even better to have an abstract Identity class from which Order/Identity and Product/Identity do extend. Where should such a common class be expected to reside? I first thought of Component/Core/Model but Component/Identity/Model could also be considered. |
|
If we do it only in core then let's go in Core namespace, but if generic and default in Product component for example, then let's go with a new component... What do you guys think? Is it generic enough to go to a component (I think it is), but let me hear your opinion. |
|
@pjedrzejewski I just had a small look at the Originator component. The documentation is unfortunately lacking and I was wondering what that will be used for and would be different from the Identification component. Anyhow, identification component could also contain (abstract) identification / mapping resolver classes. |
|
@pjedrzejewski Processed your comments, let me know what else needs to be done before it could be merged. I propose to start with having Identity class in Order, I will most likely refactor it into the Identity at a later moment. |
|
@pjedrzejewski Any feedback? |
|
@pjedrzejewski Pong |
|
@inspiran All is good, could you just generate a doctrine migration? I think diff will be enough. :) |
|
@pjedrzejewski valid point, added it. |
[Order]WIP order identities
|
Awesome, thank you Daniel! 👍 |
| @@ -19,6 +19,7 @@ | |||
| use Sylius\Component\Promotion\Model\PromotionInterface; | |||
| use Sylius\Component\Resource\Exception\UnexpectedTypeException; | |||
|
|
|||
|
|
|||
[Order]WIP order identities
[Order]WIP order identities
[Order]WIP order identities
This PR is an attempt to allow to add identities to an order. For instance, when an order is synched to an external system such as an ERP system, you would want to track the ERP order id. Similary if you would import orders from an external party (for instance ebay orders) you would want to track a reference to the ebay id.
How it currently can be used :
$identity = new Identity();
$identity->setName('ebayId');
$identity->setValue('123213213213');
$order->addIdentity($identity);
$identity = new Identity();
$identity->setName('ERP_SAP_ID);
$identity->setValue('4000123213');
$order->addIdentity($identity);
Identities are stored in table sylius_order_identities