Disable GC in PHP on Travis-CI for performance improvements #2246
Conversation
|
why don't just update composer? it is already included in the latest composer, no? |
|
And is this config cli only? if not we should reenable gc when it is done. |
|
@kayue This change has nothing to do with Composer, we already use latest (fixed one). Problem with those suits, is they generate a lot of objects (same as Composer does), and we run into same issue as Composer (in older versions). I don't get why you want to enable GC again in Travis-CI where we only use CLI... |
|
Oh I see, thanks for explanation 👍 |
|
With one suite (products) we run out of memory... so there must be leak somewhere, so this 5/10% is important, but let's see. :) Can't wait to see the result. :D |
|
@pjedrzejewski As you can see we already fail on one suite with PHP 5.3, even without this change, so leak is in master already somewhere. You can see differences i.e. on my fork vs one of latest PRs build. |
|
@pjedrzejewski @kayue @Arn0d Ok, so results are here, we have some hidden memory leak in master that leads to segfault of some suits (products?) on Travis-CI, but in overall, the whole build is being executed 1+ hour faster than before... I guess that this is pretty nice improvement ;) |
|
GG ! |
Disable GC in PHP on Travis-CI for performance improvements
|
Niiice! 👍 |
This change gives quite a lot of performance (for big suites it works 2-2,5x faster!), while unfortunately wasting a bit more memory (~5-10%).