Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scrutinizer] Ramdom fixes #2274

Merged
merged 1 commit into from
Dec 23, 2014
Merged

Conversation

arnolanglade
Copy link
Contributor

Q A
Bug fix? minor and CS
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

@arnolanglade arnolanglade force-pushed the scrutinizer_fix branch 2 times, most recently from 03d0558 to 9d38246 Compare December 23, 2014 08:26
@arnolanglade arnolanglade changed the title [WIP][scrutinizer] Ramdom fixes [scrutinizer] Ramdom fixes Dec 23, 2014
@arnolanglade
Copy link
Contributor Author

@pjedrzejewski : 52 issues were fixed! It is that the build failed like the master.

pjedrzejewski pushed a commit that referenced this pull request Dec 23, 2014
@pjedrzejewski pjedrzejewski merged commit 45c3cd4 into Sylius:master Dec 23, 2014
@pjedrzejewski
Copy link
Member

Nice, thank you Arnaud! 👍

@arnolanglade arnolanglade deleted the scrutinizer_fix branch December 23, 2014 16:05
@arnolanglade
Copy link
Contributor Author

✌️ The rating does not really change... Pity!

@pjedrzejewski
Copy link
Member

Yeah, issues are not taken into account. :)

@arnolanglade
Copy link
Contributor Author

I will update behat contexts, rewrite both methods rated F. Do you see my tweet this afternoon??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants