[ProductVariant] Added versioning for all product variant details #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <gedmo:versioned/> | ||
| </field> | ||
| <field name="sold" column="sold" type="integer"> | ||
| <gedmo:versioned/> |
There was a problem hiding this comment.
I don't think we should log this.
|
@stloyd i just made another commit and pushed to the same branch keeping in mind your comments. Should be all there now. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 26, 2015
[ProductVariant] Added versioning for all product variant details
|
Thank you Axel! 👍 |
|
@pjedrzejewski No problem. Could you take a look at #2627 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do let me know if I have to adjust anything to comply to your standards although I've made sure I comply. Love to be a contributor to this project although this is a minor fix.