Hide the "Links" sidebar widget when there are no links. #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the "Links" header to the translation mapping (en and fr).
| @@ -87,6 +87,8 @@ sylius: | |||
| login: Connexion | |||
| logout: Déconnexion | |||
| register: Créer un compte | |||
| sidebar: | |||
There was a problem hiding this comment.
This should be reverted. New translation are added only to en, then it's updated on Crowdin & if translated there, it's auto updated in repository (from time to time)...
|
@stloyd Ok, it's done ! What about a |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 13, 2015
Hide the "Links" sidebar widget when there are no links.
|
Thanks Antoine! I'd not bother with fixing the current layout, because - http://sylius.org/blog/frontend-redesign-with-chilid-part-2 |
|
Oh, thanks for the link, I'll follow their progress ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add the "Links" header to the translation mapping (en and fr).
I'm not sure how to add the
'sylius.frontend.menu.sidebar.links'translation to other languages, especially given that their mappings' indentations are inconsistent (sometimes 2 spaces, sometimes 4).This PR is mostly a paper-cut fix, but I'm new to Sylius so... low hanging fruit and such...
Also, maybe the Links widget should be in his own block, to ease overriding ? I'm not sure how you envision this ; I'm new ! :)
Do tell me if you think this needs more work, I plan to spend some time on Sylius in the next couple of months.