Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VariationBundle] Require driver node definition #2379

Merged

Conversation

adamelso
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2348
License MIT
Doc PR n/a

As reported in the Fix Ticket, the following code in SyliusVariationExtension would error when $driver is set to null by default. This PR requires driver to be configured (though, only one value is supported at present).

$choiceTypeClasses = array(
    SyliusResourceBundle::DRIVER_DOCTRINE_ORM => 'Sylius\Bundle\VariationBundle\Form\Type\OptionEntityChoiceType'
);

$optionChoiceFormType = new Definition($choiceTypeClasses[$driver]);

@stloyd
Copy link
Contributor

stloyd commented Jan 24, 2015

👍

pjedrzejewski pushed a commit that referenced this pull request Jan 24, 2015
…onfig

[VariationBundle] Require driver node definition
@pjedrzejewski pjedrzejewski merged commit 25190e5 into Sylius:master Jan 24, 2015
@pjedrzejewski
Copy link
Member

Thanks Adam! 👍

@adamelso adamelso deleted the fix-variation-bundle-exposed-config branch January 24, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants