SyliusReportBundle #2422
Merged
SyliusReportBundle #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guys, looks interesting, but seriously you should squash those commits few tiems, over 90 is way to much to easily review ;) |
| @@ -0,0 +1,41 @@ | |||
| <?php | |||
|
|
|||
| namespace Sylius\Bundle\CoreBundle\DataFetcher; | |||
|
nice bundle |
| $dateInterval = new \DateInterval($configuration['interval']); | ||
| $numberOfPeriods = $configuration['start']->diff($configuration['end']); | ||
|
|
||
| for ($i = 0; $i <= $numberOfPeriods->format($configuration['periodFormat']); $i++) { |
There was a problem hiding this comment.
You should avoid function call in loop, assign it to variable:
$numberOfPeriods = $configuration['start']->diff($configuration['end'])->format($configuration['periodFormat']);
for ($i = 0; $i <= $numberOfPeriods; $i++) {
}
Zales0123
force-pushed
the
sylius-report-bundle
branch
from
79a1a66
to
82a4937
Compare
| /** | ||
| * @param Request $request | ||
| * | ||
| * @return Response |
There was a problem hiding this comment.
Should be Symfony\Component\HttpFoundation\Response - add use statement
|
@Zales0123 You use PHP 5.4 only syntax (array access) in TableRenderer and spec fails on 5.3. (see travis) Please remove these and it will turn green. |
Zales0123
force-pushed
the
sylius-report-bundle
branch
from
b912870
to
b93c496
Compare
|
Just a bit of visual feedback - do the Time Period dropdown and the Filter button really need to be that loooooooooooooong? |
| private $emails = array( | ||
| 'order_comment', | ||
| 'order_confirmation', | ||
| 'customer_welcome', | ||
| ); |
There was a problem hiding this comment.
Please remove, wrong rebase.
|
Thanks guys, nice work! 👍 |
|
👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
SyliusReportBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyliusReportBundle - flexible reports system, based on data fetchers and renderers. Now it's extremely easy to create a report with whatever data you want and nice look. Some default data fetchers and renderers already implemented, but adding another ones is a piece of cake. Find out more: Sylius/Sylius-Docs#251
