[SearchBundle] Allow false value for enabled pre search filter field #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using cannotBeEmpty on a boolean node does not allow to use false as value.
egeloen
changed the title
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 3, 2015
[SearchBundle] Allow false value for enabled pre search filter field
|
Thank you Eric! 👍 |
|
I guess better would be to use |
|
Basically, I don't understand what #2418 tries to do. Currently, the tree forces us to put a taxonomy pre search filter even if we disable the feature... Should I switch it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This PR fixes an issue introduced in #2418. Using
cannotBeEmptyon a boolean node seems to not allow us to use false as value.