Permalinks for taxons

[gonzalovilaseca]

This fixes the permalink generation TODO in taxons.
I've basically added some customization to the TreeHander. I couldn't extend that class as it has private attributes, so I had to copy the whole class.

The handler is located in src/Sylius/Bundle/TranslationBundle/GedmoHandler, if there is a better place to put it just let me know.

[pjedrzejewski]

?

[gonzalovilaseca]

Sorry..I didn't push the latest changes where I adressed this... :-)

[gonzalovilaseca]

I'm going to have a look at the failing tests. Will update ASAP.

[gonzalovilaseca]

@pjedrzejewski The failing test is this one:

    Scenario: Creating new taxon with existing name under given taxonomy
        Given I am on the page of taxonomy "Category"
          And I follow "Create taxon"
         When I fill in "Name" with "Electronics"
          And I press "Create"
         Then I should be on the page of taxonomy "Category"
          And I should see "Taxon has been successfully created."
          And I should see 9 taxons in the list

This test assumes we can have the same taxon name for two different taxons under the same taxonomy, that would mean two identic permalinks pointing to different taxons, and that is not correct, isn't it?

[michalmarcinkowski]

@pjedrzejewski @gonzalovilaseca
I think we should allow for Taxons with the same name, but not under the same parent.

Valid scenario

Electronics > PC
Electronics > Featured
Clothes > T-Shirts
Clothes > Featured

Invalid scenario

Electronics > PC
Electronics > Featured
Clothes > T-Shirts
Clothes > T-Shirts*
Clothes > Featured

*should not be allowed

If we go this way, the failed scenario is invalid and should be replaced with similar examples as these above. In that case the permalink will do the validation job and we should only check for its uniqueness.

[gonzalovilaseca]

That is how it's set up right now, that's why the test fails. I agree with you, let's see what pawel says.

[gonzalovilaseca]

PR updated with tests passing. I added a test that needs to be implemented (I don't have the time right now).

[pjedrzejewski]

Thank you Gonzalo! 👍