fix(LocaleBundle): Changing locale using PUT, PATCH works now. #2536

aramalipoor · 2015-03-04T09:04:13Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	-
License	MIT
Doc PR	-

I needed to change locale using PATCH like below:

acme_api_locale_current_put:
    path: /current
    methods: [PUT, PATCH]
    defaults:
        _controller: sylius.controller.locale:changeAction

But changeAction threw an error:

Controller "Sylius\Bundle\LocaleBundle\Controller\LocaleController::changeAction()"
requires that you provide a value for the "$locale" argument
(because there is no default value or because there is a non optional argument after this one).

stloyd · 2015-03-04T09:16:24Z

@pjedrzejewski @Arn0d Sounds reasonable...

pjedrzejewski · 2015-03-04T10:07:29Z

src/Sylius/Bundle/LocaleBundle/Controller/LocaleController.php

        $this->getLocaleContext()->setLocale($locale);

+        $config = $this->getConfiguration();


You can just do $this->config.

aramalipoor · 2015-03-04T11:42:45Z

@pjedrzejewski Is it ok? :)

amenophis · 2015-03-04T11:47:35Z

@aramalipoor Please squash your commits

…PUT, PATCH work. fix(LocaleBundle): Do not redirect on changeAction when it's an API request.

fix(LocaleBundle): Changing locale using PUT, PATCH works now.

pjedrzejewski · 2015-03-04T15:24:18Z

Thank you Aram! 👍

pjedrzejewski reviewed Mar 4, 2015
View reviewed changes

fix(LocaleBundle): Remove $locale argument from changeAction to make …

d8b5349

…PUT, PATCH work. fix(LocaleBundle): Do not redirect on changeAction when it's an API request.

pjedrzejewski pushed a commit that referenced this pull request Mar 4, 2015

Merge pull request #2536 from aramalipoor/patch-1

16e249a

fix(LocaleBundle): Changing locale using PUT, PATCH works now.

pjedrzejewski merged commit 16e249a into Sylius:master Mar 4, 2015

aramalipoor deleted the patch-1 branch March 9, 2015 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(LocaleBundle): Changing locale using PUT, PATCH works now. #2536

fix(LocaleBundle): Changing locale using PUT, PATCH works now. #2536

aramalipoor commented Mar 4, 2015

stloyd commented Mar 4, 2015

pjedrzejewski Mar 4, 2015

aramalipoor commented Mar 4, 2015

amenophis commented Mar 4, 2015

pjedrzejewski commented Mar 4, 2015

		$this->getLocaleContext()->setLocale($locale);

		$config = $this->getConfiguration();

fix(LocaleBundle): Changing locale using PUT, PATCH works now. #2536

fix(LocaleBundle): Changing locale using PUT, PATCH works now. #2536

Conversation

aramalipoor commented Mar 4, 2015

stloyd commented Mar 4, 2015

pjedrzejewski Mar 4, 2015

Choose a reason for hiding this comment

aramalipoor commented Mar 4, 2015

amenophis commented Mar 4, 2015

pjedrzejewski commented Mar 4, 2015