Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid not found VarUtils #259

Closed
wants to merge 1 commit into from
Closed

avoid not found VarUtils #259

wants to merge 1 commit into from

Conversation

cordoval
Copy link
Contributor

No description provided.

@pjedrzejewski
Copy link
Member

Not sure what you mean here? Could you squash the 2 commits into one? "trust me" isn't the best commit message.

@cordoval
Copy link
Contributor Author

@pjedrzejewski done, hope it helps

you discouraged my french translator and judged my book without even seen its contents ... sad

@pjedrzejewski
Copy link
Member

With all due respect Luis, I just allowed myself to question the sense and quality of book which describes (partially) Sylius.

In the "free sample" you say that anyone will become a Symfony2 e-commerce expert after reading this book. Are you sure?

Sylius is still in development, I'm dedicating all my resources and time to push towards a stable release, but we're not there yet. I'm quite sure that many texts you wrote already (or planned) are outdated and will confuse people - why? Tomorrow I'm going to push new events system for checkout, which moves the whole taxation and shipping charges engine to event-based approach. Today I merged more documentation on the new shipping rules system. Will you update your book with that?

In the screenshot you published I see already confusing titles, like "Fixing Sylius" or "Creating orders manually".

I know you're active in OSS community and I greatly appreciate it, because I love open source. That's why Sylius is free, MIT licensed. Anyone who ever developed and maintained library of any size, will know, how much work it requires. I greatly appreciate anyone who hangs out here, contributing, discussing or even reporting issues. I talk to people, I pretty much know who deployed anything Sylius-powered to production... You appear week ago with a book, advertising it as Sylius & Vespolina guides and introduction to Symfony2 e-commerce world for 30 bucks.

Long story short, my only concern is misinformation and mixing up the order of things. Seriously, help us out with the stable release, become a Sylius expert, then write a book. I'll be happy to answer all your questions and buy few copies for a couple of friends.

@pjedrzejewski
Copy link
Member

I believe this is not right place to discuss such things, anyway I thought you deserve an answer. Attacking you was never my intention, but making sure that people wanting to use/using Sylius are not misinformed, is my job.

@cordoval
Copy link
Contributor Author

@pjedrzejewski thanks for your answer, I am updating it yeah and definitely people will see this.

For instance I am a ware of the breaks that were introduced in the relationships and some other errors. For instance sometime we were using sylius_core_x table instead of the sylius_x table and renaming columns with foreign keys is not simple to migrate. As a lean book whoever has deployed a solution like mine has to deal with taking a store over that change even if it is not stable. In Lean it does not have to be stable to get out of the door a MVP.

Then it came 2-3 and I basically upgraded, I have not even deployed the upgrade but wanted to make sure I polish on details. I know several things and I realize it on the same store, what is working and what not. So the book goes
around this a bit but since it is lean and I have not written the rest of the chapters I have accommodated for this room. The other thing is yeah it does not touch Sylius only so that makes it more for people to get acquainted with the status of some components be it sylius or not. Because there are people doing stores now.

So thanks for your clarification. I know it was not your intention, but oh well let's just keep working, things happen.

Thanks for sharing your concern, I think i will make me work harder to ensure this happens and covers that concern.

👍 hope to see you on Warsaw hope I can make it.

@cordoval
Copy link
Contributor Author

about the change I think it gave me an error on a not found class because of assetic library that needs to be a little bump up, it is all, did you include this already or should i rebase?

@cordoval
Copy link
Contributor Author

i think this assetic problem must be solved by now so closing

@cordoval cordoval closed this Aug 25, 2013
@cordoval cordoval deleted the patch-2 branch August 25, 2013 09:22
pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants