Throw event before and after sending email #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO this should be part of #2482 (ping @amenophis)... |
|
Yes, definitively, wasn't aware of that PR! |
|
@gonzalovilaseca Can you adjust your PR as the #2482 was merged? |
|
Sure! |
|
Ok, I've moved the events to an events class instead of the interface and adapted to the new structure. Let me know your thoughts. |
| @@ -62,7 +64,7 @@ public function render(EmailInterface $email, array $data = array()) | |||
| } | |||
|
|
|||
| /** @var EmailEvent $event */ | |||
| $event = $this->dispatcher->dispatch(self::EVENT_EMAIL_RENDERED, new EmailEvent(new RenderedEmail($subject, $body))); | |||
| $event = $this->dispatcher->dispatch(SyliusMailerEvents::EVENT_EMAIL_RENDERED, new EmailRenderEvent(new RenderedEmail($subject, $body))); | |||
There was a problem hiding this comment.
Maybe rename all events like this SyliusMailerEvents::EMAIL_RENDERED ?
|
@pjedrzejewski @Arn0d @amenophis ping ;) |
| use Sylius\Component\Mailer\Model\EmailInterface; | ||
| use Sylius\Component\Mailer\Renderer\Adapter\AbstractAdapter; | ||
| use Sylius\Component\Mailer\Renderer\RenderedEmail; | ||
| use Sylius\Component\Mailer\SyliusMailerEvents; | ||
|
|
||
| /** | ||
| * Default Sylius mailer using Twig and SwiftMailer. |
There was a problem hiding this comment.
This comments where in your master, will change them though.
|
PR updated! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Apr 14, 2015
Throw event before and after sending email
|
Thank you Gonzalo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our app we need to add custom headers before sending emails, and thought this might be something other people could need.
Also in
src/Sylius/Bundle/CoreBundle/DependencyInjection/SyliusCoreExtension.phpthe mailer services where not being loaded (don't know if this is on purpose or not).