Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PricingBundle] Remove unnecessary complexity #2639

Merged
merged 1 commit into from Apr 2, 2015
Merged

[PricingBundle] Remove unnecessary complexity #2639

merged 1 commit into from Apr 2, 2015

Conversation

aramalipoor
Copy link
Contributor

@pjedrzejewski @stloyd I'm working on a AngularJS admin and now that I'm working on field prototypes this portion of code is breaking my code.

I expect prototypes var to contain an associative array in which the keys are exactly equal to the values that the "value provider" field generates (in this PricingBundle case, the pricingCalculator is the "value provider").

So that I can find appropriate calculator prototype based on current pricingCalculator value on my forms.

I took a quick look around the whole source code and couldn't find any use of $group prefix for prototypes array.

@stloyd
Copy link
Contributor

stloyd commented Apr 2, 2015

@aramalipoor Sounds reasonable for me.

pjedrzejewski pushed a commit that referenced this pull request Apr 2, 2015
[PricingBundle] Remove unnecessary complexity
@pjedrzejewski pjedrzejewski merged commit a314283 into Sylius:master Apr 2, 2015
@pjedrzejewski
Copy link
Member

Cool, thank you!

@aramalipoor aramalipoor deleted the fix/pricing branch April 2, 2015 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants