Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RbacBundle] Allow deep merging for roles_hierarchy #2669

Merged
merged 1 commit into from Apr 22, 2015
Merged

[RbacBundle] Allow deep merging for roles_hierarchy #2669

merged 1 commit into from Apr 22, 2015

Conversation

aramalipoor
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

I needed to append some roles under administrator in my project. In fact I have a plugin system so that every bundle has its own config.yml, hence they might try to add addtional roles under adminstrator.

Since currently there is no way to dynamically modify Rbac information I thought I can use symfony's config merging as an easy way to extend rbac in my plugins, but to be able to do that I need to remove performNoDeepMerging from roles_hierarchy.

Do you guys think it's safe and right to do this on original RbacBundle?

/cc @pjedrzejewski @stloyd

pjedrzejewski pushed a commit that referenced this pull request Apr 22, 2015
[RbacBundle] Allow deep merging for roles_hierarchy
@pjedrzejewski pjedrzejewski merged commit e4aa096 into Sylius:master Apr 22, 2015
@pjedrzejewski
Copy link
Member

Sounds good, thank you Aram!

@aramalipoor aramalipoor deleted the fix/rbac-bundle-deep-merging branch April 22, 2015 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants