[RbacBundle] Allow deep merging for roles_hierarchy #2669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to append some roles under
administrator
in my project. In fact I have a plugin system so that every bundle has its ownconfig.yml
, hence they might try to add addtional roles under adminstrator.Since currently there is no way to dynamically modify
Rbac
information I thought I can use symfony's config merging as an easy way to extendrbac
in my plugins, but to be able to do that I need to removeperformNoDeepMerging
fromroles_hierarchy
.Do you guys think it's safe and right to do this on original
RbacBundle
?/cc @pjedrzejewski @stloyd