Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create routes with GET parameters. #2711

Merged
merged 1 commit into from
May 5, 2015
Merged

Create routes with GET parameters. #2711

merged 1 commit into from
May 5, 2015

Conversation

kayue
Copy link
Contributor

@kayue kayue commented May 5, 2015

Without this change, in API returns, it will generate prev / next page route without get parameter, and it can be a problem sometimes.

Before

"next": {
  "href": "http://example.com/search?page=2"
}

After

"next": {
  "href": "http://example.com/search?page=2&keyword=foo"
}

@stloyd
Copy link
Contributor

stloyd commented May 5, 2015

👍

1 similar comment
@Shine-neko
Copy link
Contributor

👍

arnolanglade added a commit that referenced this pull request May 5, 2015
@arnolanglade
Merge pull request #2711 from kayue/patch-4
7424c83 
Create routes with GET parameters.
@arnolanglade arnolanglade merged commit 7424c83 into Sylius:master May 5, 2015
@arnolanglade
Copy link
Contributor

Thank you Ka Yue!

@pjedrzejewski
Copy link
Member

Nice! 👍

@kayue kayue deleted the patch-4 branch May 5, 2015 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kayue @stloyd @Shine-neko @arnolanglade @pjedrzejewski